feat(Engine): Evaluate from EvaluationContext #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emyller
force-pushed
the
feat/context-values
branch
6 times, most recently
from
8a8c07a to
3f2eaf4
Compare
emyller
force-pushed
the
feat/context-values
branch
from
3f2eaf4 to
7295ca8
Compare
emyller
commented
Sep 25, 2025
Comment on lines
+191
to
+234
| $any = false; | ||
| foreach ($rule->conditions as $condition) { | ||
| $conditionMatches = self::_contextMatchesCondition( | ||
| $context, | ||
| $condition, | ||
| $segmentKey, | ||
| ); | ||
|
|
||
| switch ($rule->type) { | ||
| case SegmentRuleType::ALL: | ||
| if (!$conditionMatches) { | ||
| return false; | ||
| } | ||
| break; | ||
| case SegmentRuleType::NONE: | ||
| if ($conditionMatches) { | ||
| return false; | ||
| } | ||
| break; | ||
| case SegmentRuleType::ANY: | ||
| if ($conditionMatches) { | ||
| $any = true; | ||
| break 2; | ||
| } | ||
| break; | ||
| } | ||
| } | ||
|
|
||
| if ($rule->type === SegmentRuleType::ANY && !$any) { | ||
| return false; | ||
| } | ||
|
|
||
| foreach ($rule->rules as $subRule) { | ||
| $ruleMatches = self::_contextMatchesRule( | ||
| $context, | ||
| $subRule, | ||
| $segmentKey, | ||
| ); | ||
| if (!$ruleMatches) { | ||
| return false; | ||
| } | ||
| } | ||
|
|
||
| return true; |
There was a problem hiding this comment.
Note
Compared to the Python SDK's, this is improved with short-circuiting in both conditions and sub-rule testing.
emyller
commented
Sep 25, 2025
Comment on lines
+44
to
+48
| // Hack to allow comparing flags as associative arrays (<feature_name>: <flag>) | ||
| $wanted = array_column($expectedEvaluationResult->flags, null, 'name'); | ||
| $expectedEvaluationResult->flags = $wanted; | ||
| $actual = array_column($evaluationResult->flags, null, 'name'); | ||
| $evaluationResult->flags = $actual; |
There was a problem hiding this comment.
Note
I would prefer EvaluationResult->flags to be an associative array <feature_name> => <flag>, rather than an indexed array. This would improve data consistency and avoid this hack. cc @khvn26
emyller
commented
Sep 25, 2025
Comment on lines
+31
to
+51
| /** @return array<string, mixed> */ | ||
| public function jsonSerialize(): array | ||
| { | ||
| $json = [ | ||
| 'key' => $this->key, | ||
| 'feature_key' => $this->feature_key, | ||
| 'name' => $this->name, | ||
| 'enabled' => $this->enabled, | ||
| 'value' => $this->value, | ||
| ]; | ||
|
|
||
| if ($this->priority !== null) { | ||
| $json['priority'] = $this->priority; | ||
| } | ||
|
|
||
| if ($this->variants) { | ||
| $json['variants'] = $this->variants; | ||
| } | ||
|
|
||
| return $json; | ||
| } |
There was a problem hiding this comment.
Note
This only exists because the keys variants and priority are nullable in the compiled context. It can be avoided if both values are always present in the context but with insignificant values, such as rules and conditions are empty arrays by default.
emyller
force-pushed
the
feat/context-values
branch
from
38c5cef to
fe68922
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #98
The engine work is largely inspired by flagsmith-engine.
Note
Notes are added to call for discussion or follow up.