fix: include annotated methods in parameterized classes when filtering with test-targets #2537
+608
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lyokone
reviewed
Nov 7, 2024
test_runner/src/test/kotlin/ftl/run/platform/android/CreateAndroidTestContextKtTest.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where annotated test methods in classes annotated with
@RunWith(Parameterized::class)were not included in test runs when using test-targets to filter by annotation. Now, parameterized test methods with the specified annotation are correctly included in the generatedandroid_shards.jsonwhen running Flank with the--dump-shardsoption.Fixes #2480
Test Plan
A unit test has been added to verify this fix.
The test passes with the current fix applied.
The test fails without the fix, confirming the issue and validating the solution.
Checklist