-
Notifications
You must be signed in to change notification settings - Fork 5
feat/Enable overriding Flatfile default loading component #216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mattheri
wants to merge
11
commits into
FlatFilers:main
Choose a base branch
from
mattheri:feature/enable-loading-component-override-on-angular
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
ed20a11
Enable Loading component overrride on Angular
poka-matheriault 6c6b01f
Enable overriding default lodaing indicator with custom one
poka-matheriault 78a3c6c
Enable overriding default loading component in Angular
poka-matheriault 678a440
Add markForCheck when changing spaceProps
poka-matheriault 1bf3bb3
Remove console.error
mattheri 8484bd0
Sync with main
mattheri 970e9a6
remove old component
mattheri 45bdcd9
Update proud-books-rush.md
mattheri 6518009
Update proud-books-rush.md
mattheri f7a4920
Merge branch 'main' into feature/enable-loading-component-override-on…
mattheri a280246
Merge branch 'main' into feature/enable-loading-component-override-on…
mattheri File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@flatfile/angular-sdk': minor | ||
| --- | ||
|
|
||
| Allow overriding the default loading component in Angular by assigning a custom TemplateRef to the ISpace['loading'] property. This enables users to replace the default loading spinner with their own loading template. |
22 changes: 15 additions & 7 deletions
22
packages/angular/angular-sdk/src/lib/sdk/space.component.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.