Feature/http logger #272
Feature/http logger #272
Conversation
|
📝 Documentation updates detected! You can review documentation updates here |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
|
|
||
| | Parameter | Type | Description | | ||
| |-----------|------|-------------| | ||
| | `logData.error` | boolean | Whether the request resulted in an error | |
There was a problem hiding this comment.
The error parameter is marked as required in the README table but is optional in the code
| | `logData.method` | string | HTTP method used (GET, POST, etc.) | | ||
| | `logData.url` | string | Request URL | | ||
| | `logData.startTime` | Date | When the request started | | ||
| | `logData.headers` | Object | Response headers | |
There was a problem hiding this comment.
The headers parameter is marked as required in the README table but is optional in the code
| | `logData.startTime` | Date | When the request started | | ||
| | `logData.headers` | Object | Response headers | | ||
| | `logData.statusCode` | number | Response status code | | ||
| | `logData.requestSize` | number | Size of request in bytes | |
There was a problem hiding this comment.
The requestSize parameter is marked as required in the README table but is optional in the code
| | `logData.headers` | Object | Response headers | | ||
| | `logData.statusCode` | number | Response status code | | ||
| | `logData.requestSize` | number | Size of request in bytes | | ||
| | `logData.responseSize` | number | Size of response in bytes | |
There was a problem hiding this comment.
The responseSize parameter is marked as required in the README table but is optional in the code
| | `logData.statusCode` | number | Response status code | | ||
| | `logData.requestSize` | number | Size of request in bytes | | ||
| | `logData.responseSize` | number | Size of response in bytes | | ||
| | `logData.isStreaming` | boolean | Whether this is a streaming response | |
There was a problem hiding this comment.
The isStreaming parameter is marked as required in the README table but is optional in the code
| const chunkSize = Buffer.isBuffer(chunk) ? chunk.length : Buffer.byteLength(chunk, encoding || 'utf8') | ||
| requestSize += chunkSize | ||
| } | ||
| return originalWrite.apply(this, arguments) |
There was a problem hiding this comment.
Using arguments object directly is discouraged in modern JavaScript. Consider using rest parameters
| } | ||
| } | ||
|
|
||
| // eslint-disable-next-line |
There was a problem hiding this comment.
Eslint-disable comments should specify which rule is being disabled
| } | ||
|
|
||
| // eslint-disable-next-line | ||
| requestLogger(require("http")) |
There was a problem hiding this comment.
Using require() in an ES module can cause compatibility issues
1 participant
Summary by mrge
Added a new @flatfile/http-logger package to log HTTP and fetch requests in Node.js, including request/response sizes, status codes, and streaming detection.