fix: skip namespace prompt in deploy command when --ci flag is used #290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents CI pipelines from hanging on interactive namespace input when no namespace is provided via options or environment variables. Co-authored-by: Amp <amp@ampcode.com> Amp-Thread-ID: https://ampcode.com/threads/T-e49789ac-7df6-4ae9-a3f6-11b7739ad3f5
|
📝 Documentation updates detected! New suggestion: Document CLI deploy command --ci flag bug fix in libraries changelog |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the CLI deploy command's incomplete handling of the --ci flag.
Problem
The namespace prompt in the deploy command was not respecting the --ci flag, causing CI pipelines to hang when:
Solution
Added a check for the --ci flag in the namespace prompt condition. Now the prompt is skipped in CI mode, preventing pipeline blocking.
Changes
Testing
The fix ensures that in CI mode, the deploy command will proceed without interactive prompts for namespace input.