Conversation
I make the tests call the general `call_api` instead of the specific `call_openweatherapi`. I also generalized the name of the mock response to be called `mock_api_response`. Signed-off-by: Devansh Sharma <46666171+devansh287@users.noreply.github.com>
nhoening
approved these changes
Jun 24, 2025
nhoening
left a comment
nhoening
left a comment
There was a problem hiding this comment.
I'm happy that the GitHub Action stream is turning green again!
But I did find something I overlooked in the larger PR, which I don't think is elegant. Let's merge this one, and I'll add a new issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I make the tests call the general
call_apifunction instead of the specificcall_openweatherapi. I also generalized the name of the mock response to be calledmock_api_response.This is to address the issue #4.
Closes #4