Register unity without config file #286
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| namespace NewPlatform.Flexberry.ORM.ODataService.Tests | ||
| { | ||
| using System; | ||
| using System.Collections; | ||
| using System.Configuration; | ||
| using System.Globalization; | ||
| using System.Linq; | ||
|
There was a problem hiding this comment. После System-юзингов желательно пустую строчку. |
||
|
|
||
| using Microsoft.Practices.Unity.Configuration; | ||
| using Unity; | ||
| using Unity.Injection; | ||
| using Xunit; | ||
|
|
||
| /// <summary> | ||
| /// Class for checking that a dependency registered in the code can be overriden from the config. | ||
| /// </summary> | ||
| public class CheckLoadConfigurationTest | ||
|
There was a problem hiding this comment. Нужны комментарии к классу тестов. |
||
| { | ||
| [Fact] | ||
| public void CheckIfLoadConfigurationWorks() | ||
| { | ||
| using var container = new UnityContainer(); | ||
|
|
||
| // Default culture | ||
| container.RegisterType<IFormatProvider, CultureInfo>( | ||
| new InjectionConstructor("en-US")); | ||
|
|
||
| // This type is registered in code only. Just to prove its registration survives. | ||
| container.RegisterType<IList, ArrayList>(); | ||
|
|
||
| Assert.Equal("$1,234.56", GetFormattedSum(container.Resolve<IFormatProvider>(), 1234.56M)); | ||
| string beforeLoad = GetCodeRegistration(container); | ||
|
|
||
| // Override with the config file | ||
| if (ConfigurationManager.GetSection("unity") != null) | ||
| { | ||
| container.LoadConfiguration(); | ||
| Assert.Equal("1.234,56 kr.", GetFormattedSum(container.Resolve<IFormatProvider>(), 1234.56M)); | ||
|
|
||
| string afterLoad = GetCodeRegistration(container); | ||
|
|
||
| Assert.Equal(beforeLoad, afterLoad); | ||
| } | ||
| } | ||
|
|
||
| private static string GetFormattedSum(IFormatProvider fp, decimal money) | ||
| { | ||
| var fi = fp.GetFormat(typeof(NumberFormatInfo)) as NumberFormatInfo; | ||
| return string.Format(fi, "{0:C}", money); | ||
| } | ||
|
|
||
| private static string GetCodeRegistration(IUnityContainer container) | ||
| { | ||
| var reg = container.Registrations.Single(r => r.RegisteredType == typeof(IList)); | ||
| return reg.MappedToType.Name; | ||
| } | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Мне вот эта регистрация очень интересна, проходит ли корректно. Можешь убрать все регистрации в коде, потом сделать получение dataServiceForAuditAgentManagerAdapter. Мне очень интересно, как оно разрешает конструктор "BusinessServerProvider(IServiceProvider serviceProvider)". Нужно под дебагом посмотреть, инициализируется ли приватное свойство "serviceProvider".
Дело в том, что регистрация "unityContainer.RegisterFactory(new Func<IUnityContainer, object>(o => new BusinessServerProvider(new UnityServiceProvider(o))), FactoryLifetime.Singleton);" была наверчена от того, что конфиг в теории не должен был дать это нормально разрешить. Соответственно, если это работает, то круто, об этом нужно сообщить мне, я включу в свои документы. Если это не работает, а срабатывало только от того, что юнити так сильно не проверяло, то нужно оставить в конфиге только работающее.
Либо возможно работает, потому что сейчас в коде фабрика дорегистрируется IBusinessServerProvider как фабрика. Это тоже хороший вариант, о котором нужно мне сказать.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done