#303 Change mssql image on fixed #304
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -1,26 +1,52 @@ | ||||||||||||||||||||||||||
| # Integration Tests | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| ## Tests run Postgres | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| Before start test run please fill connection string `ConnectionStringPostgres` in `App.config` like this: | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| ```xml | ||||||||||||||||||||||||||
| <add name="ConnectionStringPostgres" connectionString="SERVER=localhost;User ID=postgres;Password=p@ssw0rd;Port=5432;" /> | ||||||||||||||||||||||||||
| ``` | ||||||||||||||||||||||||||
| Install [Docker](https://docker.com) if it not installed yet and start Docker. | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| Then start Docker container with PostgreSQL by command from root folder this repository: | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| ```sh | ||||||||||||||||||||||||||
| docker-compose up -d | ||||||||||||||||||||||||||
| ``` | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| Tests ready to run. Do it now. | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| When the database is no longer needed for tests, run the command: | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| ```sh | ||||||||||||||||||||||||||
| docker-compose down | ||||||||||||||||||||||||||
| ``` | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| Also perform undo in App.config before commit changes. | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| ## Test run MSSQL | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| Before start test run please fill connection string `ConnectionStringMssql` in `App.config` like this: | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| ```xml | ||||||||||||||||||||||||||
| <add name="ConnectionStringMssql" connectionString="SERVER=localhost;User ID=sa;Password=p@ssw0rd;" /> | ||||||||||||||||||||||||||
| ``` | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| Install [Docker](https://docker.com) if it not installed yet and start Docker. | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| Then start Docker container with Microsoft SQL Server by command from root folder this repository: | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| ```sh | ||||||||||||||||||||||||||
| docker-compose -f docker-compose-mssql.yml up -d | ||||||||||||||||||||||||||
| ``` | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| Tests ready to run. Do it now. | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
|
Comment on lines
+41
to
+44
There was a problem hiding this comment. 🛠️ Refactor suggestion Add MSSQL readiness check before running tests. Microsoft SQL Server takes some time to initialize. Add a note about checking the container's readiness: Add this section after the docker-compose command: docker-compose -f docker-compose-mssql.yml up -d
+
+# Wait for MSSQL to be ready (typically 10-15 seconds)
+# You can check the container logs to ensure MSSQL is ready:
+docker-compose -f docker-compose-mssql.yml logs mssql
+# Look for the message: "SQL Server is now ready for client connections"
Tests ready to run. Do it now.📝 Committable suggestion
Suggested change
|
||||||||||||||||||||||||||
| When the database is no longer needed for tests, run the command: | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| ```sh | ||||||||||||||||||||||||||
| docker-compose down | ||||||||||||||||||||||||||
| ``` | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| Also perform undo in App.config before commit changes. | ||||||||||||||||||||||||||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| version: '3.2' | ||
|
|
||
| services: | ||
| mssql: | ||
| image: mcr.microsoft.com/mssql/server:2022-CU10-ubuntu-20.04 | ||
| environment: | ||
| - ACCEPT_EULA=Y | ||
| - MSSQL_SA_PASSWORD=p@ssw0rd | ||
| ports: | ||
| - 1433:1433 | ||
| volumes: | ||
| - mssqldb:/var/opt/mssql | ||
|
|
||
| volumes: | ||
| mssqldb: |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix duplicate framework condition in ItemGroup.
There's a duplicate
net7.0in the condition which should be removed:📝 Committable suggestion