Skip to content

feat(vpc): import vpc resource and add unit test and docs #1057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Zhukun-Huawei
Copy link
Contributor

What this PR does / why we need it:
add vpc resources/data sources for flexibleengine, including vpc_subnets, vpcs
Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:

PR Checklist

  • Tests added/passed.
  • Documentation updated.
  • Schema updated.

Acceptance Steps Performed

vpc_subnets
=== RUN   TestAccVpcSubnetsDataSource_basic
=== PAUSE TestAccVpcSubnetsDataSource_basic
=== CONT  TestAccVpcSubnetsDataSource_basic
--- PASS: TestAccVpcSubnetsDataSource_basic (147.13s)
PASS
coverage: 1.7% of statements in ../../../terraform-provider-flexibleengine/...
vpcs 
=== RUN   TestAccVpcsDataSource_basic
=== PAUSE TestAccVpcsDataSource_basic
=== CONT  TestAccVpcsDataSource_basic
--- PASS: TestAccVpcsDataSource_basic (163.35s)
PASS
coverage: 1.7% of statements in ../../../terraform-provider-flexibleengine/...

@Zhukun-Huawei Zhukun-Huawei force-pushed the vpc_subnets_branch branch 2 times, most recently from 0fd9937 to 3caad55 Compare November 21, 2023 11:35
@Zippo-Wang
Copy link
Contributor

/lgtm

@github-actions github-actions bot added the LGTM label Nov 21, 2023
@ShiChangkuo ShiChangkuo merged commit b2fa237 into FlexibleEngineCloud:master Nov 23, 2023
@Zhukun-Huawei Zhukun-Huawei deleted the vpc_subnets_branch branch December 26, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants