feat(SDRS): Synchronized SDRS dataSources, unit test and document. #1098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dengyali0125
force-pushed
the
dev_sdrs_datasource
branch
from
47bf40b to
cda0918
Compare
Zippo-Wang
reviewed
Jan 26, 2024
Comment on lines
+390
to
+391
| "flexibleengine_sdrs_domain_v1": sdrs.DataSourceSDRSDomain(), | ||
|
|
There was a problem hiding this comment.
This name is not expected to be here. It should not under the // importing existing data source
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue this PR fixes:
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)fixes #xxx
Special notes for your reviewer:
Release note:
PR Checklist
Acceptance Steps Performed
flexibleengine_sdrs_domain_v1
=== RUN TestAccSDRSDomainDataSource_basic
=== PAUSE TestAccSDRSDomainDataSource_basic
=== CONT TestAccSDRSDomainDataSource_basic
--- PASS: TestAccSDRSDomainDataSource_basic (83.70s)
PASS