Handle NotFoundExceptions when modifying & deleting reminders

Would have been thrown when modifying or deleting a reminder whose initial message was deleted & interrupted modification/deletion Resolves #28
FloatingMilkshake · Dec 14, 2024 · 85fc76e · 85fc76e
1 parent 3343321
commit 85fc76e
Show file tree

Hide file tree

Showing 2 changed files with 35 additions and 20 deletions.
diff --git a/Commands/ReminderCommands.cs b/Commands/ReminderCommands.cs
@@ -342,22 +342,29 @@ await ctx.FollowupAsync(
 
         if (!reminder.IsPrivate && reminder.ReminderTime is not null)
         {
-            var reminderChannel = await Program.Discord.GetChannelAsync(reminder.ChannelId);
-
-            if (reminder.MessageId != default)
+            try
             {
-                var reminderMessage = await reminderChannel.GetMessageAsync(reminder.MessageId);
+                var reminderChannel = await Program.Discord.GetChannelAsync(reminder.ChannelId);
+
+                if (reminder.MessageId != default)
+                {
+                    var reminderMessage = await reminderChannel.GetMessageAsync(reminder.MessageId);
 
-                var unixTime = ((DateTimeOffset)reminder.ReminderTime).ToUnixTimeSeconds();
-
-                if (reminderMessage.Content.Contains("pushed back"))
-                    await reminderMessage.ModifyAsync(
-                        $"[Reminder](https://discord.com/channels/{reminder.GuildId}/{reminder.ChannelId}/{reminder.MessageId})" +
-                        $" pushed back to <t:{unixTime}:F> (<t:{unixTime}:R>)!" +
-                        $"\nReminder ID: `{reminder.ReminderId}`");
-                else
-                    await reminderMessage.ModifyAsync($"Reminder set for <t:{unixTime}:F> (<t:{unixTime}:R>)!" +
-                                                      $"\nReminder ID: `{reminder.ReminderId}`");
+                    var unixTime = ((DateTimeOffset)reminder.ReminderTime).ToUnixTimeSeconds();
+
+                    if (reminderMessage.Content.Contains("pushed back"))
+                        await reminderMessage.ModifyAsync(
+                            $"[Reminder](https://discord.com/channels/{reminder.GuildId}/{reminder.ChannelId}/{reminder.MessageId})" +
+                            $" pushed back to <t:{unixTime}:F> (<t:{unixTime}:R>)!" +
+                            $"\nReminder ID: `{reminder.ReminderId}`");
+                    else
+                        await reminderMessage.ModifyAsync($"Reminder set for <t:{unixTime}:F> (<t:{unixTime}:R>)!" +
+                                                          $"\nReminder ID: `{reminder.ReminderId}`");
+                }
+            }
+            catch
+            {
+                // Not important
             }
         }
 

diff --git a/Events/ComponentInteractionEvent.cs b/Events/ComponentInteractionEvent.cs
@@ -401,14 +401,22 @@ await e.Interaction.CreateResponseAsync(DiscordInteractionResponseType.ChannelMe
 
                 if (!reminder!.IsPrivate)
                 {
-                    var reminderChannel = await Program.Discord.GetChannelAsync(reminder.ChannelId);
-
-                    if (reminder.MessageId != default)
+                    try
                     {
-                        var reminderMessage = await reminderChannel.GetMessageAsync(reminder.MessageId);
-
-                        await reminderMessage.ModifyAsync("This reminder was deleted.");
+                        var reminderChannel = await Program.Discord.GetChannelAsync(reminder.ChannelId);
+
+                        if (reminder.MessageId != default)
+                        {
+                            var reminderMessage = await reminderChannel.GetMessageAsync(reminder.MessageId);
+
+                            await reminderMessage.ModifyAsync("This reminder was deleted.");
+                        }
+                    }
+                    catch
+                    {
+                        // Not important
                     }
+
                 }
 
                 await Program.Db.HashDeleteAsync("reminders", e.Values[0]);