Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instance Settings page requesting httpToken list when not enabled for team #4382

Closed
sentry-io bot opened this issue Aug 15, 2024 · 0 comments · Fixed by #4487
Closed

Instance Settings page requesting httpToken list when not enabled for team #4382

sentry-io bot opened this issue Aug 15, 2024 · 0 comments · Fixed by #4487
Assignees
Labels
area:frontend For any issues that require work in the frontend/UI bug Something isn't working size:XS - 1 Sizing estimation point
Milestone

Comments

@sentry-io
Copy link

sentry-io bot commented Aug 15, 2024

The Instance Settings Security page will show a list of HTTP Access Tokens if the FF User Auth option is enabled.

That option is gated on both the platform feature flag and the team type feature flag.

However the request to load the instance tokens is only gated by the platform feature flag.

So when a Starter team accesses that page, even though the option is disabled, we're still making a request to load the tokens under the covers. This correctly returns a 404 which throws an unhandled error under the covers.

There is no impact to the user, but this unhandled error is being reported by Sentry.

The request to get tokens (line 161 frontend/src/pages/instance/Settings/Security.vue) needs to check the team type feature flag as well as the platform flag.

Sentry Issue: FLOWFUSE-FRONTEND-59

AxiosError: Request failed with status code 404
  at Lt (/app/vendors.f3f35300cdfa825dec32.js:2:744787)
  at XMLHttpRequest.g (/app/vendors.f3f35300cdfa825dec32.js:2:749434)
  at pe.request (/app/vendors.f3f35300cdfa825dec32.js:2:757319)
  at async Proxy.getTokens (/app/main.43b5a997bb88bec17808.js:1:1020348)
@sentry-io sentry-io bot added area:frontend For any issues that require work in the frontend/UI bug Something isn't working size:XS - 1 Sizing estimation point labels Aug 15, 2024
@knolleary knolleary added this to the 2.8 milestone Aug 15, 2024
@joepavitt joepavitt modified the milestones: 2.8, 2.9 Aug 29, 2024
@hardillb hardillb self-assigned this Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:frontend For any issues that require work in the frontend/UI bug Something isn't working size:XS - 1 Sizing estimation point
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants