Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only get tokens if team feature enabled #4487

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Conversation

hardillb
Copy link
Contributor

fixes #4382

Description

Prevents the UI from trying to access Bearer tokens if the FlowFuse User Authentication is not enabled for the team.

Related Issue(s)

#4382

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.12%. Comparing base (90dc872) to head (7bc4426).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4487      +/-   ##
==========================================
- Coverage   78.15%   78.12%   -0.04%     
==========================================
  Files         296      296              
  Lines       14125    14125              
  Branches     3189     3189              
==========================================
- Hits        11040    11035       -5     
- Misses       3085     3090       +5     
Flag Coverage Δ
backend 78.12% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hardillb hardillb merged commit 64c25bd into main Sep 16, 2024
13 of 14 checks passed
@hardillb hardillb deleted the 4382-dont-try-and-get-tokens branch September 16, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Instance Settings page requesting httpToken list when not enabled for team
2 participants