Improve canceled subs handling #3148
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3148 +/- ##
==========================================
+ Coverage 39.82% 40.31% +0.49%
==========================================
Files 582 582
Lines 21247 21356 +109
Branches 5103 5144 +41
==========================================
+ Hits 8461 8610 +149
+ Misses 12786 12746 -40
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Pezmc
reviewed
Dec 6, 2023
Pezmc
reviewed
Dec 6, 2023
Pezmc
reviewed
Dec 6, 2023
Pezmc
reviewed
Dec 6, 2023
Pezmc
approved these changes
Dec 6, 2023
Co-authored-by: Pez Cuckow <email@pezcuckow.com>
knolleary
commented
Dec 6, 2023
Pezmc
approved these changes
Dec 6, 2023
|
@knolleary did you want to include this in the billing fix push to prod? It will need the merge conflicts fixing |
|
@hardillb no, need to revisit this before it merges. For another day. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This improves our handling around canceled stripe subscriptions.
We have seen a couple instances where subscription is canceled on stripe, but our local state thinks it is active.
This PR adds a check whenever we come to do billable work to resync our local status with the true stripe status. If we find the status has changed, and that it is now canceled, we suspend all team instances and log it.
It also:
billing.subscription.updatedaudit-log event