Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto genrate license and display #4105

Merged
merged 5 commits into from
Jul 17, 2024
Merged

auto genrate license and display #4105

merged 5 commits into from
Jul 17, 2024

Conversation

sumitshinde-84
Copy link
Contributor

@sumitshinde-84 sumitshinde-84 commented Jul 4, 2024

Description

This pull request automates the generation and display of licenses for requesters. It integrates with our existing Node-RED application (sales flows) to handle license generation. The PR initiates a POST request to an API endpoint within the Node-RED instance. This endpoint generates the license and returns it in the response. Following this, it triggers further flows to store the information in context storage, display it on the dashboard, and log it on Google Sheets.

After the requesting license, requester can see it as following

WhatsApp Image 2024-07-05 at 5 50 27 PM (1)

Related Issue(s)

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@joepavitt
Copy link
Contributor

Worth putting a note below the license key once it's there to make sure the user copies it, as it won't be available again if they leave/come back/refresh the screen?

@sumitshinde-84
Copy link
Contributor Author

Thanks, @joepavitt, for the suggestion! Yes, it is necessary to add that note; I will update it.

@ZJvandeWeg
Copy link
Member

Approved from my side, @joepavitt can you do the honours with review?

@joepavitt
Copy link
Contributor

joepavitt commented Jul 5, 2024

will do, waiting on #4105 (comment) to be actioned first

@sumitshinde-84
Copy link
Contributor Author

hi @joepavitt , I have updated the Pr to include the note and made some improvement in license block

@joepavitt
Copy link
Contributor

There is still a sentence there after the code block saying "your license will be sent yo you within the next business day" - we don't need that anymore.

I'd also move the <strong /> content into it's own paragraph too to make sure it catches users' eyes

@sumitshinde-84
Copy link
Contributor Author

sumitshinde-84 commented Jul 5, 2024

There is still a sentence there after the code block saying "your license will be sent yo you within the next business day" - we don't need that anymore.

I'd also move the <strong /> content into it's own paragraph too to make sure it catches users' eyes

Yes, that sentence is the HubSpot form submit response. I'm not sure how to remove it; I think this should be done within HubSpot. Furthermore, I have moved the strong content into its own paragraph.

@sumitshinde-84
Copy link
Contributor Author

@joepavitt i have made an update to this PR, now it will not show the HS thank you message.

@joepavitt joepavitt merged commit 913b744 into main Jul 17, 2024
8 checks passed
@joepavitt joepavitt deleted the auto-genrate-license branch July 17, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants