Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap maps with arrays on the applications page #4148

Conversation

cstns
Copy link
Contributor

@cstns cstns commented Jul 9, 2024

Description

use arrays instead of maps for application devices and instances on the applications page

Related Issue(s)

part of #4014

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.76%. Comparing base (8718b1d) to head (9432591).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4148   +/-   ##
=======================================
  Coverage   78.76%   78.76%           
=======================================
  Files         286      286           
  Lines       13053    13053           
  Branches     2910     2910           
=======================================
  Hits        10281    10281           
  Misses       2772     2772           
Flag Coverage Δ
backend 78.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cstns cstns requested a review from joepavitt July 9, 2024 16:44
@joepavitt joepavitt merged commit 3dc892a into main Jul 10, 2024
14 checks passed
@joepavitt joepavitt deleted the use-arrays-instead-of-maps-for-application-devices-and-instances branch July 10, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants