-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add session ownerId/type to log output if set #4155
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4155 +/- ##
==========================================
- Coverage 78.76% 78.65% -0.12%
==========================================
Files 286 286
Lines 13055 13087 +32
Branches 2911 2922 +11
==========================================
+ Hits 10283 10293 +10
- Misses 2772 2794 +22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved in the interest of time with the knowledge ownerType
and ownerId
are (currently) only set to specific values in the src, however we should have tests that ensure IDs are alphanumeric
Scratch that, i would prefer we are explicit rather than have a default case. Will make a suggestion. Test would be good too, but less important if we are explicit
Add headers identifying the owner in requests to assistant service
Adds info on who is making http requests when using an access token rather than user session. For device/team tokens, ensures the hashid is provided. Project tokens are uuids already.