-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search applications by instances and devices #4159
Conversation
… needing to add associations limit
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4159 +/- ##
=======================================
Coverage 78.65% 78.65%
=======================================
Files 286 286
Lines 13093 13093
Branches 2924 2925 +1
=======================================
Hits 10298 10298
Misses 2795 2795
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
The only thing that worries me is that I had to remove the ASSOCIATIONS_LIMIT that restricted app instances/devices count in order for the search function to work on entities that are hidden by the 'x more...' tile. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice.
I do have one super simple suggestion regarding UX:
When I search for something and realise there are more matching my search criteria, when I click More
I expected my search term to be carried over. Instead, i had to re-type my search term.
Carrying my search term to the next page would feel much more consistent.
Otherwise, excellent.
Thank you for the positive feedback!
I have to admit I did not think of that use case, there's added value in it!
Yes, the search function can be extended easily to include id search for app/instance/device. I'll create a follow up task to include them |
Description
Add the ability to search through an application's devices and instances
Related Issue(s)
closes #4157
Checklist
flowforge.yml
?FlowFuse/helm
to update ConfigMap TemplateFlowFuse/CloudProject
to update values for Staging/ProductionLabels
area:migration
label