Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search applications by instances and devices #4159

Merged
merged 9 commits into from
Jul 11, 2024

Conversation

cstns
Copy link
Contributor

@cstns cstns commented Jul 11, 2024

Description

Add the ability to search through an application's devices and instances

Related Issue(s)

closes #4157

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

Copy link

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.65%. Comparing base (87cfe11) to head (03457d8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4159   +/-   ##
=======================================
  Coverage   78.65%   78.65%           
=======================================
  Files         286      286           
  Lines       13093    13093           
  Branches     2924     2925    +1     
=======================================
  Hits        10298    10298           
  Misses       2795     2795           
Flag Coverage Δ
backend 78.65% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cstns
Copy link
Contributor Author

cstns commented Jul 11, 2024

The only thing that worries me is that I had to remove the ASSOCIATIONS_LIMIT that restricted app instances/devices count in order for the search function to work on entities that are hidden by the 'x more...' tile.

@cstns cstns self-assigned this Jul 11, 2024
@cstns cstns requested review from joepavitt and Steve-Mcl July 11, 2024 13:36
Copy link
Contributor

@Steve-Mcl Steve-Mcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice.

I do have one super simple suggestion regarding UX:

When I search for something and realise there are more matching my search criteria, when I click More I expected my search term to be carried over. Instead, i had to re-type my search term.

chrome_owWRavH3Tt

Carrying my search term to the next page would feel much more consistent.

Otherwise, excellent.

@Steve-Mcl
Copy link
Contributor

Sorry, one more thing.

Do you have access to the ID and Type when performing the search?

I tried searching NUC (a type value) and nkDqdOYgxM (a device ID) - but the search did NOT reveal any results whereas on the next page it does.

chrome_1Fxicw5DL7

@cstns
Copy link
Contributor Author

cstns commented Jul 11, 2024

Thank you for the positive feedback!

Carrying my search term to the next page would feel much more consistent.

I have to admit I did not think of that use case, there's added value in it!

Do you have access to the ID and Type when performing the search?

Yes, the search function can be extended easily to include id search for app/instance/device.

I'll create a follow up task to include them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search/Filter applications based on instance/device name
2 participants