Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add meta-information to docs #4175

Closed
wants to merge 3 commits into from
Closed

Conversation

sumitshinde-84
Copy link
Contributor

Description

Related Issue(s)

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@knolleary
Copy link
Member

@sumitshinde-84 checking this is ready to review?

@sumitshinde-84
Copy link
Contributor Author

Not yet. I will let you know when it is ready for review.

@hardillb
Copy link
Contributor

@sumitshinde-84 where are we with this please?

@hardillb
Copy link
Contributor

@sumitshinde-84 How are we doing here?

Also can you resolve the merge conflicts if this is moving forwards. Thanks

@sumitshinde-84
Copy link
Contributor Author

Oh, I forgot about this PR. I’ll get it ready today. Sorry for that!

@hardillb
Copy link
Contributor

@sumitshinde-84 it looks like when you merged main into this branch it removed all the changes. Is this correct? If so we can just close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants