Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add license and trial status to assistant request #4189

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

Steve-Mcl
Copy link
Contributor

Description

Builds on #4182 and adds additional header info (license status, tier, trial status) to assistant requests so that actions and decisions can be made accordingly

Related Issue(s)

https://github.com/FlowFuse/security/issues/95
Part of https://github.com/FlowFuse/security/issues/92#issuecomment-2225045049

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@Steve-Mcl
Copy link
Contributor Author

@hardillb adding yourself as reviewer as you are familiar with the route now having done #4182 (and this one is branched of/merges into 4182)

Please merge this into 4182 first before we merge that into main.

@Steve-Mcl Steve-Mcl requested a review from hardillb July 16, 2024 17:06
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 3 lines in your changes missing coverage. Please review.

Project coverage is 78.63%. Comparing base (ff54e3c) to head (38c0df4).

Files Patch % Lines
forge/routes/api/assistant.js 85.71% 3 Missing ⚠️
Additional details and impacted files
@@                      Coverage Diff                       @@
##           sec92-rate-limit-assistant    #4189      +/-   ##
==============================================================
+ Coverage                       78.61%   78.63%   +0.02%     
==============================================================
  Files                             286      286              
  Lines                           13103    13106       +3     
  Branches                         2930     2931       +1     
==============================================================
+ Hits                            10301    10306       +5     
+ Misses                           2802     2800       -2     
Flag Coverage Δ
backend 78.63% <85.71%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Steve-Mcl
Copy link
Contributor Author

We can ignore pre-staging failure as we dont yet have a means of testing assistant stuff on pre-staging (issue has been raised for that here: https://github.com/FlowFuse/CloudProject/issues/475)

(though @ppawlowski might want to take a look at why that step failed?)

@ppawlowski
Copy link
Contributor

ppawlowski commented Jul 16, 2024

(though @ppawlowski might want to take a look at why that step failed?)

It failed due to the lack of resources on the cluster.

@Steve-Mcl Steve-Mcl merged commit e2b0860 into sec92-rate-limit-assistant Jul 16, 2024
13 of 14 checks passed
@Steve-Mcl Steve-Mcl deleted the sec92-team0info branch July 16, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants