Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix limbo state after leaving last team #4226

Merged
merged 2 commits into from
Jul 22, 2024
Merged

Fix limbo state after leaving last team #4226

merged 2 commits into from
Jul 22, 2024

Conversation

Steve-Mcl
Copy link
Contributor

@Steve-Mcl Steve-Mcl commented Jul 19, 2024

closes #4026

Description

  • Awaits teams refresh
  • checks team count, if zero, sets own team to null
    • this causes links in sidebar to correctly change from "back to dashboard" to "back to create team"

Before

msedge_FV52eeS0X8

After

msedge_wLFTIgQnvV

Related Issue(s)

#4026

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@Steve-Mcl Steve-Mcl requested a review from knolleary July 19, 2024 16:26
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.64%. Comparing base (940a813) to head (84f6bac).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4226   +/-   ##
=======================================
  Coverage   78.64%   78.64%           
=======================================
  Files         286      286           
  Lines       13119    13119           
  Branches     2934     2934           
=======================================
  Hits        10317    10317           
  Misses       2802     2802           
Flag Coverage Δ
backend 78.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knolleary knolleary merged commit da3a11e into main Jul 22, 2024
14 checks passed
@knolleary knolleary deleted the 4026-fix-limbo branch July 22, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Users are left in a limbo state after leaving the only team they are part of.
2 participants