Do not store modified email when deduping email list #4232
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4222
Description
A previous fix (#2543) was applied to de-duplicate the emails provided in the Team Invite flow, including stripping
.
from gmail addresses.However, stripping the
.
lead to an unexpected behaviour:foo.bar@gmail.com
foobar@gmail.com
, follows the linkfoobar@gmail.com
- corrects it to their preferred addressfoo.bar@gmail.com
This fixes this scenario by still deduplicating the emails via their canonical version, but it then stores the unaltered email rather than the canonical version. This better aligns with the expected result.