Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assets Service - UX to add/delete/modify files and folders on the Node-RED filesystem #4398

Merged
merged 22 commits into from
Aug 28, 2024

Conversation

joepavitt
Copy link
Contributor

@joepavitt joepavitt commented Aug 23, 2024

Description

  • Adds a new "Assets" tab
  • Supports creation, updating and deletion of Folders
  • Supports file uploads (up to 5 MB currently due to API limitations)

Todo

  • E2E Tests
  • Documentation
Screen.Recording.2024-08-23.at.17.01.38.mov

Requirements

  • driver-localfs: add-file-api
  • nr-launcher: file-api

Follow Up

Allow for users to control "visibility"/"share" functionality of each folder so that it becomes available via HTTP endpoints/Dashboard

Related Issue(s)

First part of #4358

@hardillb hardillb changed the base branch from main to 4357-file-api August 23, 2024 16:13
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.22%. Comparing base (f949923) to head (d173842).
Report is 23 commits behind head on 4357-file-api.

Additional details and impacted files
@@              Coverage Diff               @@
##           4357-file-api    #4398   +/-   ##
==============================================
  Coverage          78.22%   78.22%           
==============================================
  Files                294      294           
  Lines              13848    13848           
  Branches            3117     3117           
==============================================
  Hits               10833    10833           
  Misses              3015     3015           
Flag Coverage Δ
backend 78.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cstns
Copy link
Contributor

cstns commented Aug 27, 2024

I've put in place some checks that prevent unnecessary api calls to the assets endpoint when the feature is disabled or the nr-launcher version does not match the required version.

sample.mov

@cstns
Copy link
Contributor

cstns commented Aug 27, 2024

Also treated the use case where the instance is suspended/suspending/starting

sample.mov

@cstns cstns marked this pull request as ready for review August 28, 2024 12:19
@hardillb hardillb merged commit cc2908c into 4357-file-api Aug 28, 2024
16 checks passed
@hardillb hardillb deleted the 4358-assets-ui branch August 28, 2024 13:06
@cstns cstns mentioned this pull request Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants