Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds LDAP group support #4407

Merged
merged 7 commits into from
Aug 28, 2024
Merged

Adds LDAP group support #4407

merged 7 commits into from
Aug 28, 2024

Conversation

hardillb
Copy link
Contributor

fixes #4002

Description

Adds support for controlling team membership with LDAP groups

I've tested this with my local LDAP instance.

Updated UI

image

It reuses parts from the SAML group support where possible.

There may be some code duplication in the group managemnts, but as they exist in different areas I didn't re-factor them out to a shared function.

Related Issue(s)

#4002

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@hardillb hardillb added this to the 2.8 milestone Aug 27, 2024
@hardillb hardillb self-assigned this Aug 27, 2024
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 59 lines in your changes missing coverage. Please review.

Project coverage is 78.18%. Comparing base (8c97fec) to head (845cec1).
Report is 8 commits behind head on main.

Files Patch % Lines
forge/ee/lib/sso/index.js 0.00% 59 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4407      +/-   ##
==========================================
- Coverage   78.52%   78.18%   -0.34%     
==========================================
  Files         294      294              
  Lines       13694    13753      +59     
  Branches     3082     3099      +17     
==========================================
  Hits        10753    10753              
- Misses       2941     3000      +59     
Flag Coverage Δ
backend 78.18% <0.00%> (-0.34%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

docs/admin/sso/ldap.md Outdated Show resolved Hide resolved
forge/ee/lib/sso/index.js Outdated Show resolved Hide resolved
docs/admin/sso/ldap.md Outdated Show resolved Hide resolved
forge/ee/lib/sso/index.js Outdated Show resolved Hide resolved
Co-authored-by: Stephen McLaughlin <44235289+Steve-Mcl@users.noreply.github.com>
Copy link
Contributor

@Steve-Mcl Steve-Mcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code wise, it all looks good however I have no way of trying this out and in the spirit of "done" I have to ask about tests. There is no coverage for the new functionality

Happy to approve if there is a follow up raised and @joepavitt agrees.

@hardillb
Copy link
Contributor Author

@Steve-Mcl all the new functions require a live LDAP server.

And Nick is probably the only other person with a LDAP setup to test against.

@Steve-Mcl
Copy link
Contributor

@Steve-Mcl all the new functions require a live LDAP server.

And Nick is probably the only other person with a LDAP setup to test against.

Indeed which is why I would be ok with approving this so long as there is a follow up task and @joepavitt is on-board.

@joepavitt
Copy link
Contributor

Agreed. Happy to proceed

@Steve-Mcl Steve-Mcl self-requested a review August 28, 2024 09:28
Copy link
Contributor

@Steve-Mcl Steve-Mcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending follow up issue raised to bring test coverage up

forge/ee/lib/sso/index.js Outdated Show resolved Hide resolved
@hardillb
Copy link
Contributor Author

@Steve-Mcl #4416

@hardillb hardillb merged commit 648d717 into main Aug 28, 2024
13 of 14 checks passed
@hardillb hardillb deleted the ldap-group-support branch August 28, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LDAP: support team membership management
3 participants