Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the application activity instance selector, TeamSelection and FormRow dropdown with the listbox component #4591

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

cstns
Copy link
Contributor

@cstns cstns commented Sep 30, 2024

Description

Related Issue(s)

closes #4561

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@cstns cstns self-assigned this Sep 30, 2024
@cstns cstns changed the title Replace the activity instance selector with the listbox component Replace the applicatoin activity instance selector, TeamSelection and FormRow dropdown with the listbox component Sep 30, 2024
…dropdowns' into 4561_replace-the-applicationActivity-formRow-and-teamSlection-dropdowns
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.26%. Comparing base (8acfed2) to head (f9d907a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4591   +/-   ##
=======================================
  Coverage   78.26%   78.26%           
=======================================
  Files         302      302           
  Lines       14348    14348           
  Branches     3262     3262           
=======================================
  Hits        11229    11229           
  Misses       3119     3119           
Flag Coverage Δ
backend 78.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cstns cstns changed the title Replace the applicatoin activity instance selector, TeamSelection and FormRow dropdown with the listbox component Replace the application activity instance selector, TeamSelection and FormRow dropdown with the listbox component Sep 30, 2024
Base automatically changed from 4562_replace-assetCompare-visibility-selector-and-logs-dropdowns to main October 1, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace the Application Activity, FormRow & TeamSelection ff-dropdown with the new ff-listbox component
2 participants