Add Device Group env vars API support#4659
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4659 +/- ##
==========================================
+ Coverage 78.53% 78.59% +0.06%
==========================================
Files 303 304 +1
Lines 14399 14470 +71
Branches 3285 3303 +18
==========================================
+ Hits 11308 11373 +65
- Misses 3091 3097 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
knolleary
left a comment
There was a problem hiding this comment.
Looks good - one pending question about a commented out function. Approved pending resolution of the question.
Add UI for Device Group Env Setup
|
Thanks Nick. I will do final a ux test on pre-staging instance & use that to grab screenshots for changelog. Once I get docs done & approved, I'll merge this. |
closes #4658
Description
Route added
PUT/api/v1/applications/:applicationId/device-groups/:groupId/settingsenvarray of objectsNOTE: Adding endpoint vs updating the
PUT /api/v1/applications/:applicationId/device-groups/:groupIdroutewas a toss of a coin. Instances overload the
PUT /api/v1/projects/:idroute allowing for thesettings to be updated in the same request. However, devices have a separate route
PUT /api/v1/devices/:deviceIdroute.Since devices and device groups are closer in relation, I decided to follow suit. I did however structure this is a way that we can easily remove this endpoint and map the feature to the existing route if so desired
Specified behaviour
application:device-group:updatepermission was re-used for this purposeenvarray of objects is merged with the existing member devices only in theliveAPI (when a device is requesting settings)settingsand saving will trigger all member devices to update their settings hashTests added
Related Issue(s)
Owner: #4658
Parent: #4538
Checklist
flowforge.yml?FlowFuse/helmto update ConfigMap TemplateFlowFuse/CloudProjectto update values for Staging/ProductionLabels
area:migrationlabel