Move instance pages under team namespace #4905
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd immersive editor routes from top level routes
- used named routes - used the hidden key to hide options - switched to the featuresCheck ux store getter
- basically an iteration of the same principle, include the account store team and add the team slug to instance routes
2 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## add-a-team-link-component-to-simplify-routing #4905 +/- ##
================================================================================
Coverage ? 78.44%
================================================================================
Files ? 325
Lines ? 15353
Branches ? 3529
================================================================================
Hits ? 12043
Misses ? 3310
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
- stop teleporting the platform banner while on the immersive editor because that's using the plain layout which doesn't include the placeholder
cstns
changed the base branch from
main
to
fix-application-child-routes-not-making-the-applications-nav-menu-active
|
Given the high number of changed files, it would be easier to review on a commit basis from the commits tab |
Base automatically changed from
fix-application-child-routes-not-making-the-applications-nav-menu-active
to
main
December 18, 2024 09:51
cstns
changed the base branch from
main
to
add-a-team-link-component-to-simplify-routing
…nder-team-namespace
…e-instance-pages-under-team-namespace # Conflicts: # frontend/src/pages/device/index.vue
…e-instance-pages-under-team-namespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue(s)
part of #4836
Checklist
flowforge.yml?FlowFuse/helmto update ConfigMap TemplateFlowFuse/CloudProjectto update values for Staging/ProductionLabels
area:migrationlabel