Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a team link component to simplify routing #4942

Open
wants to merge 3 commits into
base: app-routes-follow-up
Choose a base branch
from

Conversation

cstns
Copy link
Contributor

@cstns cstns commented Dec 18, 2024

Description

Adds a ff-team-link component that would simplify routes parametrization

Related Issue(s)

part of #4836

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@cstns cstns self-assigned this Dec 18, 2024
@cstns cstns changed the base branch from main to app-routes-follow-up December 18, 2024 16:41
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 54.83871% with 14 lines in your changes missing coverage. Please review.

Project coverage is 78.59%. Comparing base (311d451) to head (5597511).
Report is 15 commits behind head on app-routes-follow-up.

Files with missing lines Patch % Lines
forge/ee/lib/deviceEditor/DeviceTunnelManager.js 45.45% 12 Missing ⚠️
forge/db/controllers/Device.js 50.00% 1 Missing ⚠️
...db/migrations/20241218-01-add-nr-version-device.js 80.00% 1 Missing ⚠️
Additional details and impacted files
@@                   Coverage Diff                    @@
##           app-routes-follow-up    #4942      +/-   ##
========================================================
- Coverage                 78.64%   78.59%   -0.05%     
========================================================
  Files                       324      325       +1     
  Lines                     15265    15296      +31     
  Branches                   3507     3512       +5     
========================================================
+ Hits                      12005    12022      +17     
- Misses                     3260     3274      +14     
Flag Coverage Δ
backend 78.59% <54.83%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant