-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new team selection frontend #4943
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## allow-team-trial-creation #4943 +/- ##
=============================================================
+ Coverage 78.41% 78.46% +0.04%
=============================================================
Files 325 324 -1
Lines 15338 15307 -31
Branches 3523 3518 -5
=============================================================
- Hits 12028 12011 -17
+ Misses 3310 3296 -14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I can look at adding a quick fix on these once I've tested this as is. We know if the team type has instances available to it, just need to add the appropriate v-ifs. Once I'm done reviewing/testing this PR as-is, will see if its a quick addition in the morning.
Pipelines have never had a team-type level flag - they are available to all tiers if running with a license. We can add a feature flag if there is now a requirement for it to be team-tier dependant. But we can discuss that for a future iteration. |
line 183 on |
Have created the branch ( |
After some wrestling with cypress, I've fixed the UI tests. Going to look at the other two quick changes now. |
Description
Full Onboarding Demo for Free Tier
Screen.Recording.2024-12-18.at.17.19.29.mov
Obvious Follow Ups
/instances
page that this isn't included in the team tier, similar to how "Broker" options, etc. are shown in the left navigation.Pipelines Problem:
Noted also that Pipelines weren't shown with the same indication marker, when they should be, but actually there is no "feature flag" for this:
Related Issue(s)
https://github.com/FlowFuse/CloudProject/issues/600#issuecomment-2549085040