Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new team selection frontend #4943

Merged
merged 6 commits into from
Dec 19, 2024
Merged

Conversation

joepavitt
Copy link
Contributor

@joepavitt joepavitt commented Dec 18, 2024

Description

  • Adds new tile-based team type selection, with context/awareness of free trials being available, and relaying messaging about the need for credit cards, even though it is a free tier (something we aim to fix soon)

Full Onboarding Demo for Free Tier

Screen.Recording.2024-12-18.at.17.19.29.mov

Obvious Follow Ups

  • Remove the "auto create instance" option when creating first application
  • Some indication on the /instances page that this isn't included in the team tier, similar to how "Broker" options, etc. are shown in the left navigation.

Pipelines Problem:

Noted also that Pipelines weren't shown with the same indication marker, when they should be, but actually there is no "feature flag" for this:

Screenshot 2024-12-18 at 17 25 57

Related Issue(s)

https://github.com/FlowFuse/CloudProject/issues/600#issuecomment-2549085040

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.46%. Comparing base (7506ca6) to head (fd4d2fa).
Report is 7 commits behind head on allow-team-trial-creation.

Additional details and impacted files
@@                      Coverage Diff                      @@
##           allow-team-trial-creation    #4943      +/-   ##
=============================================================
+ Coverage                      78.41%   78.46%   +0.04%     
=============================================================
  Files                            325      324       -1     
  Lines                          15338    15307      -31     
  Branches                        3523     3518       -5     
=============================================================
- Hits                           12028    12011      -17     
+ Misses                          3310     3296      -14     
Flag Coverage Δ
backend 78.46% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knolleary
Copy link
Member

  • Remove the "auto create instance" option when creating first application
  • Some indication on the /instances page that this isn't included in the team tier, similar to how "Broker" options, etc. are shown in the left navigation.

I can look at adding a quick fix on these once I've tested this as is. We know if the team type has instances available to it, just need to add the appropriate v-ifs. Once I'm done reviewing/testing this PR as-is, will see if its a quick addition in the morning.

Noted also that Pipelines weren't shown with the same indication marker

Pipelines have never had a team-type level flag - they are available to all tiers if running with a license. We can add a feature flag if there is now a requirement for it to be team-tier dependant. But we can discuss that for a future iteration.

@joepavitt
Copy link
Contributor Author

line 183 on create.vue is where you'll be wanting to look for that

@joepavitt
Copy link
Contributor Author

Remove the "auto create instance" option when creating first application

Have created the branch (auto-instance-application) for this, it's a WIP with a small win already with respect to moving the "limit" notice. The logic on how that banner is rendered is very odd though, and needs investigating. Ideally we drive whether the checkbox is clicked by default, based on the limits

@knolleary
Copy link
Member

After some wrestling with cypress, I've fixed the UI tests. Going to look at the other two quick changes now.

@knolleary knolleary merged commit 6f14d0d into allow-team-trial-creation Dec 19, 2024
18 checks passed
@knolleary knolleary deleted the team-selection-ui branch December 19, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants