-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix race condition when changing teams while on the application page #4951
Conversation
- removed the team dispatch on beforeMount and beforeRouteEnter causing the issue - update how we change the team, updating the team is more than enough while pushing a new route for browser history consistency - a bit of code cleanup on the application page
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4951 +/- ##
=======================================
Coverage 78.44% 78.44%
=======================================
Files 325 325
Lines 15353 15353
Branches 3529 3529
=======================================
Hits 12043 12043
Misses 3310 3310
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
'/team/' + this.team?.slug + '/billing', | ||
'/team/' + this.team?.slug + '/settings', | ||
'/team/' + this.team?.slug + '/settings/general', | ||
'/team/' + this.team?.slug + '/settings/danger', | ||
'/team/' + this.team?.slug + '/settings/change-type' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this not simply return []
if team is not set?
As it stands, you will return at array containing '/team/undefined/billing'
etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Steve-Mcl have you tested it? I can confirm this PR fixes the bug that is live in production now that we should get fixed. I don't see any ill effects because of this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have you tested it?
Yes, it works well, however I only flagged this code section because the PR (on the whole) is about handling team
being undefined. By the same virtue, if team
IS undefined, then we will get a bunch of links to /undefined/
I am not blocking it - happy for the PR to be merged as is.
Issue caused by setting team sequentially while on the application page. This did not pose a problem until nesting the application pages under the team namespace
Description
Related Issue(s)
closes #4950
introduced by #4885
Checklist
flowforge.yml
?FlowFuse/helm
to update ConfigMap TemplateFlowFuse/CloudProject
to update values for Staging/ProductionLabels
area:migration
label