-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add possibility to configure securityContext
for each pod
#275
Conversation
node-red:3.0.2-main-linux-amd64 scan results1 files ±0 4 suites ±0 0s ⏱️ ±0s For more details on these failures, see this check. Results for commit 00f46d8. ± Comparison against base commit 60776ce. |
node-red:2.2.3-main-linux-amd64 scan results26 tests ±0 0 ✅ ±0 0s ⏱️ ±0s For more details on these failures, see this check. Results for commit 00f46d8. ± Comparison against base commit 60776ce. |
node-red:2.2.3-main-linux-arm64 scan results26 tests ±0 0 ✅ ±0 0s ⏱️ ±0s For more details on these failures, see this check. Results for commit 00f46d8. ± Comparison against base commit 60776ce. |
node-red:3.0.2-main-linux-arm64 scan results1 files ±0 4 suites ±0 0s ⏱️ ±0s For more details on these failures, see this check. Results for commit 00f46d8. ± Comparison against base commit 60776ce. |
@ppawlowski do we need to talk about what security context will be applied to the NR instance pods? |
NR instances are created by the application with kubernetes driver thus it is outside of the scope of the change introduced in this PR. However, it is worth to implement security context parameters on NR as well, but as a separate task. |
Yes, but I was meaning should we have a paired drive pr to match? And should it use some of the same values? |
Can be implemented independently. Regarding values - for the seccomp profile it should be fine, although some tests should be performed. For the user/group ID - this might change due to #251 . |
OK, so the only thing missing from this (we will look at the driver update later) is adding to the file-server pod |
Description
Add possibility to configure securityContext for forge and broker pods.
Additionally, set a default value for
seccompProfile
toRuntimeDefault
for both pods.Related Issue(s)
#323
#268
Checklist
flowforge.yml
?FlowFuse/helm
to update ConfigMap TemplateFlowFuse/CloudProject
to update values for Staging/ProductionLabels
backport
labelarea:migration
label