Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved messaging for error responses #24

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

Steve-Mcl
Copy link
Contributor

closes #23

Description

Improve messaging and notifications for 4xx errors
Permit custom notification text for 403 errors when the body code is "assistant_service_denied" - for feeding back info like "Trial expired"

Related Issue(s)

#23
https://github.com/FlowFuse/security/issues/92

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@Steve-Mcl Steve-Mcl requested a review from hardillb July 16, 2024 09:52
@Steve-Mcl Steve-Mcl merged commit 7cb17d6 into main Jul 16, 2024
5 checks passed
@Steve-Mcl Steve-Mcl deleted the 23-better-response-notifications branch July 16, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inform users of 429 and other Reponses in friendly manor
2 participants