Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New page on why flowforge #1065

Merged
merged 9 commits into from
Aug 28, 2023
Merged

New page on why flowforge #1065

merged 9 commits into from
Aug 28, 2023

Conversation

Yndira-E
Copy link
Contributor

@Yndira-E Yndira-E commented Aug 25, 2023

Description

Created a new page with the content described in the issue

Related Issue(s)

#1015

Checklist

  • I have read the contribution guidelines
  • I have considered the performance impact of these changes
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated

@Yndira-E Yndira-E linked an issue Aug 25, 2023 that may be closed by this pull request
@github-actions
Copy link
Contributor

Images automagically compressed by Calibre's image-actions

Compression reduced images by 74.4%, saving 465.75 KB.

Filename Before After Improvement Visual comparison
src/images/why-ff/why-ff-1.jpg 96.82 KB 24.24 KB -75.0% View diff
src/images/why-ff/why-ff-2.jpg 109.18 KB 28.67 KB -73.7% View diff
src/images/why-ff/why-ff-3.jpg 108.92 KB 27.18 KB -75.0% View diff
src/images/why-ff/why-ff-4.jpg 114.02 KB 29.77 KB -73.9% View diff
src/images/why-ff/why-ff-5.jpg 96.70 KB 25.06 KB -74.1% View diff
src/images/why-ff/why-ff-6.jpg 100.56 KB 25.54 KB -74.6% View diff

520 images did not require optimisation.

@Yndira-E
Copy link
Contributor Author

Yndira-E commented Aug 25, 2023

Hi @iskerrett here's the why ff page. We still have some work to do, but only small tasks:

  • Could you please replace the placeholder text I used with the actual description?
  • We need to decide where we're going to include this page in the nav bar.
  • And, when we have the videos on youtube, I'll replace the ones we currently have.

By the way, are we still waiting for more comments on the video? Or should I work in the other 3 we've prepared?

src/_data/reasons.json Outdated Show resolved Hide resolved
src/_data/reasons.json Outdated Show resolved Hide resolved
src/why-flowfuse.njk Outdated Show resolved Hide resolved
@iskerrett
Copy link
Contributor

Hi @iskerrett here's the why ff page. We still have some work to do, but only small tasks:

  • Could you please replace the placeholder text I used with the actual description?
  • We need to decide where we're going to include this page in the nav bar.

I suggest we add it to the product menu. I would make it the first item.

  • And, when we have the videos on youtube, I'll replace the ones we currently have.

By the way, are we still waiting for more comments on the video? Or should I work in the other 3 we've prepared?

We are still waiting for feedback. I will remind people. :-)

@iskerrett
Copy link
Contributor

btw, I really like this new page :-)

Co-authored-by: Ian Skerrett <36051834+iskerrett@users.noreply.github.com>
@iskerrett
Copy link
Contributor

I think we should also include #5 and #6. I know we won't have a video but we can add those later.

@Yndira-E Yndira-E force-pushed the 1015-new-page-on-why-flowforge branch from 2b70982 to 9ca8189 Compare August 25, 2023 16:45
@Yndira-E
Copy link
Contributor Author

I suggest we add it to the product menu. I would make it the first item.

Done

I think we should also include 5 and 6. I know we won't have a video but we can add those later.

And done!

🎉

layout: layouts/page.njk
title: Why FlowFuse?
description:
<p>Node-RED is a great low-code visual programming tool. FlowFuse adds to standard Node-RED to make it even better.</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<p>Node-RED is a great low-code visual programming tool. FlowFuse adds to standard Node-RED to make it even better.</p>
<p>Node-RED is a great low-code visual programming tool. Here are 6 things FlowFuse adds to standard Node-RED to make it even better.</p>

@Yndira-E
Copy link
Contributor Author

Yndira-E commented Aug 28, 2023

Hi @iskerrett, I've added the intros to all the videos. If you find them okay, they're ready to be uploaded to YouTube.
Please share the links when you have them so we can add them to the page.

@iskerrett
Copy link
Contributor

Hi @iskerrett, I've added the intros to all the videos. If you find them okay

Intros look good. I will upload the videos to YouTube.

@Yndira-E Yndira-E marked this pull request as ready for review August 28, 2023 15:23
@iskerrett iskerrett self-requested a review August 28, 2023 15:26
@Yndira-E Yndira-E merged commit 5a5c243 into main Aug 28, 2023
6 checks passed
@Yndira-E Yndira-E deleted the 1015-new-page-on-why-flowforge branch August 28, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New page on why FlowForge
2 participants