Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Iteration on /core-nodes nav #1145

Merged
merged 2 commits into from
Sep 22, 2023
Merged

Iteration on /core-nodes nav #1145

merged 2 commits into from
Sep 22, 2023

Conversation

Yndira-E
Copy link
Contributor

@Yndira-E Yndira-E commented Sep 21, 2023 •
edited
Loading

Description

Implemented accordion lists for each group of nodes to enhance navigation.

Related Issue(s)

#1144

Checklist

  • I have read the contribution guidelines
  • I have considered the performance impact of these changes
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated

@Yndira-E Yndira-E linked an issue Sep 21, 2023 that may be closed by this pull request
Iterate on /core-nodes style #1144
Closed
@Yndira-E
Copy link
Contributor Author

Hi @joepavitt, I think I need your help here. Let me know if you have a chance to go through it together, please 🙏

@joepavitt
Copy link
Contributor

Going to really struggle for time today, possibly available tomorrow.

@Yndira-E Yndira-E marked this pull request as ready for review September 22, 2023 13:16
@Yndira-E
Copy link
Contributor Author

@iskerrett I implemented the accordions to the left nav. You mentioned you'd also like to add links in the main page of the core-nodes, here:
Screenshot 2023-09-22 at 15 18 17

But there are no pages to link them to, the titles of the node groups don't have a page of their own.

iskerrett
iskerrett approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@iskerrett iskerrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you for this improvement.

@iskerrett iskerrett merged commit 34792da into main Sep 22, 2023
5 checks passed
@iskerrett iskerrett deleted the core-nodes-nav-iteration branch September 22, 2023 14:08
@Yndira-E Yndira-E linked an issue Sep 27, 2023 that may be closed by this pull request
Improvements to Code Node Explained Page #985
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iskerrett iskerrett iskerrett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improvements to Code Node Explained Page Iterate on /core-nodes style
3 participants
@Yndira-E @joepavitt @iskerrett