Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Landing page for FlowFuse Dashboard #2237

Merged
merged 6 commits into from
Jun 25, 2024

Conversation

Yndira-E
Copy link
Contributor

@Yndira-E Yndira-E commented Jun 21, 2024

Description

Created the landing page for FlowFuse Dashboard and added it as an item under the resources menu.

The original issue requested this to be the URL /node-red-dashboard2/ but since we re-named it, I changed the URL to /flowfuse-dashboard/

As per @Hasmin-AC request, I'll change the image to be more these. I'm leaving that for a future iteration.

Related Issue(s)

#2131

Checklist

  • I have read the contribution guidelines
  • I have considered the performance impact of these changes
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated

@Yndira-E Yndira-E linked an issue Jun 21, 2024 that may be closed by this pull request
Copy link
Contributor

Images automagically compressed by Calibre's image-actions

Compression reduced images by 72.4%, saving 167.01 KB.

Filename Before After Improvement Visual comparison
src/images/webinars/multi-user-dashboard-with-node-red-dashboard-2-0-webinar-2024-february.jpg 230.72 KB 63.70 KB -72.4% View diff

1097 images did not require optimisation.

@Yndira-E Yndira-E marked this pull request as ready for review June 21, 2024 16:57
@joepavitt
Copy link
Contributor

I do still need to actually tie up the migration service properly too, so I can do that first thing on Tuesday - possibly on Sunday.

@Hasmin-AC
Copy link
Contributor

Hasmin-AC commented Jun 21, 2024

Thanks @Yndira-E I would like to suggest listing this under the products menu instead. @ZJvandeWeg and @joepavitt WDYT?
(We would also have the /cloud and the recently suggested device manager pages listed under products as well)

@joepavitt
Copy link
Contributor

I think that's a great idea

src/flowfuse-dashboard.njk Outdated Show resolved Hide resolved
Co-authored-by: Hasmin-AC <153527883+Hasmin-AC@users.noreply.github.com>
src/flowfuse-dashboard.njk Outdated Show resolved Hide resolved
src/_includes/migration.njk Outdated Show resolved Hide resolved
src/flowfuse-dashboard.njk Outdated Show resolved Hide resolved
src/_includes/migration.njk Outdated Show resolved Hide resolved
Yndira-E and others added 2 commits June 25, 2024 10:52
Co-authored-by: Joe Pavitt <99246719+joepavitt@users.noreply.github.com>
@joepavitt
Copy link
Contributor

I do still need to actually tie up the migration service properly too, so I can do that first thing on Tuesday - possibly on Sunday.

Can confirm this is resolved. the migration service is live

@ZJvandeWeg ZJvandeWeg merged commit 9606ecd into main Jun 25, 2024
6 checks passed
@ZJvandeWeg ZJvandeWeg deleted the 2131-landing-page-for-dashboard-20 branch June 25, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Landing page for Dashboard 2.0
4 participants