Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog entry for JSON support in nr-assistant #2348

Merged
merged 9 commits into from
Jul 17, 2024

Conversation

Steve-Mcl
Copy link
Contributor

Description

Adds changelog entry for new JSON support

Related Issue(s)

#2346

Checklist

  • I have read the contribution guidelines
  • I have considered the performance impact of these changes
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated

@Steve-Mcl Steve-Mcl linked an issue Jul 15, 2024 that may be closed by this pull request
@Steve-Mcl Steve-Mcl requested a review from knolleary July 15, 2024 10:25
@Steve-Mcl
Copy link
Contributor Author

Not to be published until after nr-assistant 0.1.1 release is cut

Copy link
Contributor

Images automagically compressed by Calibre's image-actions

Compression reduced images by 17.1%, saving 12.76 KB.

Filename Before After Improvement Visual comparison
src/changelog/2024/07/images/ask-assistant-json-1a.png 9.78 KB 7.71 KB -21.2% View diff
src/changelog/2024/07/images/ask-assistant-json-1b.png 23.87 KB 20.00 KB -16.2% View diff
src/changelog/2024/07/images/ask-assistant-json-2a.png 11.22 KB 8.55 KB -23.8% View diff
src/changelog/2024/07/images/ask-assistant-json-2b.png 29.63 KB 25.48 KB -14.0% View diff

1230 images did not require optimisation.

Copy link
Contributor

Images automagically compressed by Calibre's image-actions

Compression reduced images by 17%, saving 6.00 KB.

Filename Before After Improvement Visual comparison
src/changelog/2024/07/images/ask-assistant-json-1a.png 9.40 KB 7.41 KB -21.2% View diff
src/changelog/2024/07/images/ask-assistant-json-1b.png 25.89 KB 21.88 KB -15.5% View diff

1232 images did not require optimisation.

@Steve-Mcl Steve-Mcl requested a review from knolleary July 16, 2024 13:57
Copy link
Contributor

Images automagically compressed by Calibre's image-actions

Compression reduced images by 16.9%, saving 3.77 KB.

Filename Before After Improvement Visual comparison
src/changelog/2024/07/images/assistant-update-nr3.png 13.28 KB 11.12 KB -16.2% View diff
src/changelog/2024/07/images/assistant-update-nr4.png 9.05 KB 7.43 KB -17.9% View diff

1234 images did not require optimisation.

@knolleary knolleary merged commit dee2f48 into main Jul 17, 2024
6 checks passed
@knolleary knolleary deleted the 2346-changelog-adding-json-support-to-assistant branch July 17, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changelog: Adding JSON support to Assistant
2 participants