Using websocket with Node-RED #2672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hasmin-AC
reviewed
Oct 15, 2024
ZJvandeWeg
reviewed
Oct 16, 2024
There was a problem hiding this comment.
@sumitshinde-84 you're adding two gifs to the repo of a combined 100mb. That I don't think is a good way to go about it.
There was a problem hiding this comment.
Please compress them or just use plain mp4 or another format that doesn't require the whole page to load 100mb of data.
There was a problem hiding this comment.
Oh, I hadn’t noticed that! I think we should add the code to compress the GIFs as well which are in the /blog directory. What do you think? Also, regarding the gif's i have compressed them.
Co-authored-by: Hasmin-AC <153527883+Hasmin-AC@users.noreply.github.com>
…/website into websocket-with-node-red
sumitshinde-84
requested review from
ZJvandeWeg
and removed request for
ZJvandeWeg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue(s)
Checklist