Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean Docs Directory #965

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Clean Docs Directory #965

merged 1 commit into from
Jul 13, 2023

Conversation

Pezmc
Copy link
Contributor

@Pezmc Pezmc commented Jul 13, 2023

Description

If a file is deleted from docs, it lives to tell the tail as it never gets removed.

This PR updates the clean script to also clear the docs folder

Related Issue(s)

Checklist

  • I have read the contribution guidelines
  • I have considered the performance impact of these changes
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated

@netlify
Copy link

netlify bot commented Jul 13, 2023

Deploy Preview for flowforge-website ready!

Name Link
🔨 Latest commit 502315f
🔍 Latest deploy log https://app.netlify.com/sites/flowforge-website/deploys/64afad6c6a847d00089828fc
😎 Deploy Preview https://deploy-preview-965--flowforge-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@joepavitt joepavitt merged commit 8d67324 into main Jul 13, 2023
4 of 5 checks passed
@joepavitt joepavitt deleted the fix-clean-docs branch July 13, 2023 08:26
@Pezmc
Copy link
Contributor Author

Pezmc commented Jul 13, 2023

This seems to have broken something, checking why

@joepavitt
Copy link
Contributor

joepavitt commented Jul 13, 2023

@Pezmc looking at the package.json I don't ever see where the docs script is run during the build process? Ah it's because that happens in the GH action, which it claims, ran successfully: https://github.com/flowforge/website/actions/runs/5540819703/jobs/10113411947

@knolleary
Copy link
Member

We have reverted this PR via #966

@joepavitt
Copy link
Contributor

joepavitt commented Jul 13, 2023

@Pezmc order of build steps into production:

  • GitHub Action: npm run docs pulls docs from /flowforge
  • GitHub Action: pushes to live branch
  • Netlify: detects changes on live, pulls code
  • Netlify: runs npm run build within which it then ran delete 'src/docs/**/*.md' - and removed all the documentation

So we then lost all of the documentation in production. Locally, not an issue because the dev:docs command is running, and can just re-pull the code again.

@Pezmc Pezmc mentioned this pull request Jul 13, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants