Conversation
deploy-java.yml에서 FastAPI 관련 삭제 및 deploy-fastapi.yml 작성. docker-compose 분리 promtail 작성 logging_config.py 변경
can019
reviewed
Sep 19, 2025
| @@ -0,0 +1,37 @@ | |||
| version: "3.9" | |||
Collaborator
There was a problem hiding this comment.
이렇게 했을 때 Spring에서 http 요청 시 8000으로 쏘는건가요?
can019
reviewed
Sep 19, 2025
Comment on lines
26
to
32
| echo "DB_USER=${{ secrets.DB_USER }}" >> .env.prod | ||
| echo "DB_PASS=${{ secrets.DB_PASS }}" >> .env.prod | ||
| echo "DB_NAME=${{ secrets.DB_NAME }}" >> .env.prod | ||
| echo "ENV_NAME=${{ secrets.LOKI_URL }}" >> .env.prod | ||
| echo "ENV_NAME=${{ secrets.LOKI_USERNAME }}" >> .env.prod | ||
| echo "ENV_NAME=${{ secrets.LOKI_PASSWORD }}" >> .env.prod | ||
| echo "LOKI_HOST=${{ secrets.LOKI_HOST }}" >> .env.prod | ||
| echo "LOKI_USERNAME=${{ secrets.LOKI_USERNAME }}" >> .env.prod | ||
| echo "LOKI_PASSWORD=${{ secrets.LOKI_PASSWORD }}" >> .env.prod | ||
| echo "ENV_NAME=${{ secrets.ENV_NAME }}" >> .env.prod |
Collaborator
There was a problem hiding this comment.
java 쪽 fast api url을 넣어줘야 spring에서 호출 할 수 있을 것 같습니다
can019
requested changes
Sep 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 작업 내용
🔗 관련 이슈
💬 추가 요청사항
✅ 체크리스트
코드 품질
테스트
배포 준비