Merged
Conversation
Sebobo
force-pushed
the
feature/custom-graphql-adapter
branch
from
ae85434 to
5752843
Compare
Sebobo
force-pushed
the
feature/custom-graphql-adapter
branch
from
5752843 to
0c5f3dc
Compare
Sebobo
changed the title
Sebobo
force-pushed
the
feature/custom-graphql-adapter
branch
from
f6779ea to
c1ec73e
Compare
Sebobo
force-pushed
the
feature/custom-graphql-adapter
branch
3 times, most recently
from
27cd1ce to
0d30ebe
Compare
Sebobo
force-pushed
the
feature/custom-graphql-adapter
branch
from
0d30ebe to
6499745
Compare
Sebobo
force-pushed
the
feature/custom-graphql-adapter
branch
6 times, most recently
from
b83e3de to
b2ccf90
Compare
Sebobo
force-pushed
the
feature/custom-graphql-adapter
branch
from
b2ccf90 to
c104820
Compare
Sebobo
force-pushed
the
feature/custom-graphql-adapter
branch
from
a5ff9fd to
fa03610
Compare
Sebobo
force-pushed
the
feature/custom-graphql-adapter
branch
from
fa03610 to
ffb0fee
Compare
mhsdesign
approved these changes
May 27, 2025
Contributor
mhsdesign
left a comment
mhsdesign
left a comment
There was a problem hiding this comment.
Thank you sooo much for all the hard work and introducing types for all kind of things :)
The new media api is actually really fun and precise to skim though :D much better than neos api itself ^^
I left a bunch of things i found while reviewing - aside that the dev js version seems to be bundled no major things.
And i tested it a bit as well and it seems to behave well.
Co-authored-by: Marc Henry Schultz <85400359+mhsdesign@users.noreply.github.com>
Co-authored-by: Marc Henry Schultz <85400359+mhsdesign@users.noreply.github.com>
Added test. This broke due to an update to recoil which made prevState immutable, which makes sense.
Co-authored-by: Marc Henry Schultz <85400359+mhsdesign@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal is to replace the t3n/graphql-* packages.
This change will only support Neos 8.3 and 8.4 and lead to a new major version.
Resolves: #120
Adjusted Queries
Adjusted Mutations
Type methods
Other todos
Fix later