Implement mul for generic rate #94
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mul is already implemented for the fixed point variants of rate. This is useful when calculating rates after a PLL.
|
Thanks for this! It was intentional, but I'm starting to realize that these features do need to exist. |
|
Hi thanks for the response. Maybe this PR would need a bit more thought to be useful for the whole crate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I am currently implementing some PLL logic and stumbled over generic rate not implementing
Mul.I am not sure if this was intentional or if my implementation is missing some details. I'm happy about feedback :)
I was also thinking about implementing
Div, but I am not sure how that should affect the fraction.Thanks for the nice library,
tdittr