Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix foal connect react and support build output dir #1274

Merged
merged 4 commits into from
Aug 3, 2024
Merged

Conversation

LoicPoullain
Copy link
Member

@LoicPoullain LoicPoullain commented Aug 3, 2024

Issue

  • The command npx foal connect react does not make the react CLI proxify the request to the server anymore.
  • When the react application is built, it is not built in the public directory of the Foal server, as is the case for Angular and Vue.

Solution and steps

  • Generate environment files to fix this.

Checklist

  • Add/update/check docs (code comments and docs/ folder).
  • Add/update/check tests.
  • Update/check the cli generators.

@LoicPoullain LoicPoullain changed the title Fix "foal connect react" and support build output dir Fix foal connect react and support build output dir Aug 3, 2024
@LoicPoullain LoicPoullain mentioned this pull request Aug 3, 2024
8 tasks
@LoicPoullain LoicPoullain merged commit 9489962 into v4-5-0 Aug 3, 2024
2 checks passed
@LoicPoullain LoicPoullain deleted the react-cli branch August 3, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant