Respect source #397
Open
Respect source #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment,
glyphs.<name>.sourceset in the manifest is ignored andglyphsis generated by iterating over the files in the directory set inoptions.input.vectorsusing the codepoint set inglyphs.<name>.codepoint. However, one might have multiple codepoints with the same glyph, e.g. a placeholder or aliases, soglyphs.<name>.sourceshould be respected.With this patch, if no source was set, the source is derived from
options.input.vectorsand the name. Only ifglyphsis empty, the previous approach of deriving the glyphs by iterating over the vector-files is used.