Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pre code color #66

Merged
merged 2 commits into from
Mar 5, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dist/css/bootstrap-dark-prefers-light.css
Original file line number Diff line number Diff line change
Expand Up @@ -549,7 +549,7 @@ kbd kbd {
pre {
display: block;
font-size: 87.5%;
color: #212529;
color: #f8f9fa;
}

pre code {
Expand Down
2 changes: 1 addition & 1 deletion dist/css/bootstrap-dark-prefers-light.min.css

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions dist/css/bootstrap-dark.css

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/css/bootstrap-dark.min.css

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/css/bootstrap-light-prefers-dark.css
Original file line number Diff line number Diff line change
Expand Up @@ -11100,7 +11100,7 @@ a.text-themed:hover {
}

pre {
color: #212529;
color: #f8f9fa;
}

pre code {
Expand Down
2 changes: 1 addition & 1 deletion dist/css/bootstrap-light-prefers-dark.min.css

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/css/bootstrap-prefers-dark-color-only.css
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
background-color: #212529
}
pre {
color: #212529
color: #f8f9fa
}
pre code {
color: inherit
Expand Down
4 changes: 2 additions & 2 deletions dist/css/bootstrap-prefers-dark.css

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/css/bootstrap-prefers-dark.min.css

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions dist/css/toggle-bootstrap-dark.css

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/css/toggle-bootstrap-dark.min.css

Large diffs are not rendered by default.

10 changes: 9 additions & 1 deletion readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,15 @@ See [Contributing to ForEvolve open source projects](https://github.com/ForEvolv

# Release notes

Since CI build numbers are automated, it is hard to know in advance what the next deployed build number will be, so the `(latest`)` version represents that version.
Since CI build numbers are automated, it is hard to know in advance what the next deployed build number will be, so the `(latest)` version represents that version.

## 4.0.0

- Fix pre and code color, setting the `$pre-color` variable to `$gray-100`, overriding the default of `$gray-900` for the dark theme.

> No breaking changes expected. This version only change the code/pre color.
> The major bump is to override the pre-release package that I deprecated recently during the no abandonned PR #63.
> I was not able to delete the package on NPM, so this should fix the issue.

## 3.0.0

Expand Down
2 changes: 1 addition & 1 deletion samples/html/css/bootstrap-dark-prefers-light.css
Original file line number Diff line number Diff line change
Expand Up @@ -549,7 +549,7 @@ kbd kbd {
pre {
display: block;
font-size: 87.5%;
color: #212529;
color: #f8f9fa;
}

pre code {
Expand Down
2 changes: 1 addition & 1 deletion samples/html/css/bootstrap-dark-prefers-light.min.css

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions samples/html/css/bootstrap-dark.css

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion samples/html/css/bootstrap-dark.min.css

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion samples/html/css/bootstrap-light-prefers-dark.css
Original file line number Diff line number Diff line change
Expand Up @@ -11100,7 +11100,7 @@ a.text-themed:hover {
}

pre {
color: #212529;
color: #f8f9fa;
}

pre code {
Expand Down
2 changes: 1 addition & 1 deletion samples/html/css/bootstrap-light-prefers-dark.min.css

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion samples/html/css/bootstrap-prefers-dark-color-only.css
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
background-color: #212529
}
pre {
color: #212529
color: #f8f9fa
}
pre code {
color: inherit
Expand Down
4 changes: 2 additions & 2 deletions samples/html/css/bootstrap-prefers-dark.css

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion samples/html/css/bootstrap-prefers-dark.min.css

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions samples/html/css/toggle-bootstrap-dark.css

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion samples/html/css/toggle-bootstrap-dark.min.css

Large diffs are not rendered by default.

39 changes: 39 additions & 0 deletions samples/razor-pages/Pages/Code.cshtml
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
@page
@{
ViewData["Title"] = "Code";
}

<div class="container-fluid mt-3 mb-3">
<h2 class="mt-4">Pre</h2>

<pre>Lorem ipsum dolor sit amet, consectetur adipiscing elit.
Fusce tempor lectus vitae ante pellentesque ultrices. Sed commodo nulla sit amet risus ullamcorper, at tincidunt quam consectetur.

Suspendisse sagittis, nunc a euismod commodo, elit arcu tempor ex, in pulvinar magna enim id libero.
Ut malesuada leo quis tellus hendrerit, sit amet eleifend erat sagittis.
Vivamus aliquet porta lorem, vel maximus elit laoreet eget.

Suspendisse sed dui dapibus, rutrum nunc vel, eleifend urna.
In hac habitasse platea dictumst. Nullam fermentum, metus quis vehicula dignissim, justo nisi sollicitudin velit, sit amet volutpat eros metus vel turpis.
Donec non mauris malesuada, faucibus dolor vel, vestibulum tellus.
Sed maximus tellus vel diam dapibus, quis malesuada odio cursus.
Phasellus viverra felis eu tortor sagittis, eget consectetur mauris auctor.
In a metus nulla. Sed imperdiet mauris et quam bibendum vestibulum. Sed consectetur enim eget nunc vestibulum, at tristique dolor suscipit.

Suspendisse potenti.</pre>

<h2 class="mt-4">Pre &gt; Code</h2>
<pre><code>#include &lt;stdio.h&gt;

int main() {
int x = 5;
float y = 3.14;
char c = 'A';

printf("The value of x is %d\n", x);
printf("The value of y is %.2f\n", y);
printf("The value of c is %c\n", c);

return 0;
}</code></pre>
</div>
3 changes: 3 additions & 0 deletions samples/razor-pages/Pages/_Layout.cshtml
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,9 @@
<li class="nav-item">
<a class="nav-link" asp-page="toasts" asp-route-default-theme="@defaultTheme">Toasts</a>
</li>
<li class="nav-item">
<a class="nav-link" asp-page="code" asp-route-default-theme="@defaultTheme">Code</a>
</li>
<li class="nav-item">
<a class="nav-link" asp-page="themed" asp-route-default-theme="@defaultTheme">Themed</a>
</li>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -549,7 +549,7 @@ kbd kbd {
pre {
display: block;
font-size: 87.5%;
color: #212529;
color: #f8f9fa;
}

pre code {
Expand Down

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions samples/razor-pages/wwwroot/css/bootstrap-dark.css

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion samples/razor-pages/wwwroot/css/bootstrap-dark.min.css

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -11100,7 +11100,7 @@ a.text-themed:hover {
}

pre {
color: #212529;
color: #f8f9fa;
}

pre code {
Expand Down

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
background-color: #212529
}
pre {
color: #212529
color: #f8f9fa
}
pre code {
color: inherit
Expand Down
4 changes: 2 additions & 2 deletions samples/razor-pages/wwwroot/css/bootstrap-prefers-dark.css

Large diffs are not rendered by default.

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions samples/razor-pages/wwwroot/css/toggle-bootstrap-dark.css

Large diffs are not rendered by default.

Large diffs are not rendered by default.

4 changes: 4 additions & 0 deletions scss/_dark-variables.scss
Original file line number Diff line number Diff line change
Expand Up @@ -236,3 +236,7 @@ $pagination-active-border-color: $pagination-active-bg;
$pagination-disabled-color: $gray-400;
$pagination-disabled-bg: $black;
$pagination-disabled-border-color: $gray-700;

// Code
// $code-color: $pink;
$pre-color: $gray-100;
2 changes: 1 addition & 1 deletion version.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"$schema": "https://raw.githubusercontent.com/dotnet/Nerdbank.GitVersioning/master/src/NerdBank.GitVersioning/version.schema.json",
"version": "3.0.0",
"version": "4.0.0",
"publicReleaseRefSpec": ["^refs/heads/(main|master)$"],
"cloudBuild": {
"buildNumber": {
Expand Down