Empty archive board message will only show once the fetchBoards call …

…returns.
FordLabs · Apr 2, 2019 · a6b5f1f · a6b5f1f
1 parent ae37ca7
commit a6b5f1f
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 3 deletions.
diff --git a/ui/src/app/modules/teams/pages/archives/archives.page.html b/ui/src/app/modules/teams/pages/archives/archives.page.html
@@ -56,7 +56,7 @@
 
     <div
       class="no-archives-info"
-      *ngIf="boards.length === 0"
+      *ngIf="boards.length === 0 && !archivesAreLoading"
       [ngClass]="{
         'dark-theme': darkThemeIsEnabled
       }"

diff --git a/ui/src/app/modules/teams/pages/archives/archives.page.spec.ts b/ui/src/app/modules/teams/pages/archives/archives.page.spec.ts
@@ -72,6 +72,10 @@ describe('ArchivesPageComponent', () => {
       mockDataService.team.id = 'the id';
     });
 
+    it('should have the archives loading flag to true', () => {
+      expect(component.archivesAreLoading).toBeTruthy();
+    });
+
     it('should set the team id attribute on the component', () => {
       component.teamId = '';
       component.ngOnInit();

diff --git a/ui/src/app/modules/teams/pages/archives/archives.page.ts b/ui/src/app/modules/teams/pages/archives/archives.page.ts
@@ -37,6 +37,7 @@ export class ArchivesPageComponent implements OnInit {
   boards: Array<Board> = [];
   globalWindowRef: Window = window;
   countSortEnabled = false;
+  archivesAreLoading = true;
 
   constructor(private dataService: DataService,
               private teamsService: TeamService,
@@ -55,8 +56,12 @@ export class ArchivesPageComponent implements OnInit {
     this.dataService.themeChanged.subscribe(theme => this.theme = theme);
 
     this.boardService.fetchBoards(this.teamId).subscribe(boards => {
-      this.boards = boards;
-    });
+        this.boards = boards;
+        this.archivesAreLoading = false;
+      },
+      () => {
+        this.archivesAreLoading = false;
+      });
   }
 
   get darkThemeIsEnabled(): boolean {