Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(davinci-client): add multi-select collectors & default value sup… #13

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ryanbas21
Copy link
Collaborator

@ryanbas21 ryanbas21 commented Feb 6, 2025

JIRA Ticket

https://pingidentity.atlassian.net/browse/SDKS-3678
https://pingidentity.atlassian.net/browse/SDKS-3658

Description

Adds support for default data that is required to prefill in values. Omits support for Password Collector.

Adds Multivalue/Multiselect support

Copy link

changeset-bot bot commented Feb 6, 2025

⚠️ No Changeset found

Latest commit: bcd1d78

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

nx-cloud bot commented Feb 6, 2025

View your CI Pipeline Execution ↗ for commit bcd1d78.

Command Status Duration Result
nx affected -t typecheck build lint test docs e... ✅ Succeeded 1m 23s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 5s View ↗

☁️ Nx Cloud last updated this comment at 2025-02-06 21:03:53 UTC

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 73.40426% with 25 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@56e964d). Learn more about missing BASE report.

Files with missing lines Patch % Lines
packages/davinci-client/src/lib/node.reducer.ts 67.94% 25 Missing ⚠️

❌ Your patch status has failed because the patch coverage (73.40%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #13   +/-   ##
=======================================
  Coverage        ?   54.44%           
=======================================
  Files           ?       13           
  Lines           ?     1686           
  Branches        ?      120           
=======================================
  Hits            ?      918           
  Misses          ?      768           
  Partials        ?        0           
Files with missing lines Coverage Δ
packages/davinci-client/src/lib/collector.utils.ts 97.11% <100.00%> (ø)
packages/davinci-client/src/lib/node.slice.ts 87.78% <100.00%> (ø)
packages/davinci-client/src/lib/node.reducer.ts 83.92% <67.94%> (ø)

Copy link
Contributor

github-actions bot commented Feb 6, 2025

Deployed 3a58729 to https://ForgeRock.github.io/ping-javascript-sdk/pr-13/3a58729f91428ba94ddcdeceb6006c6e5c2d9777 branch gh-pages in ForgeRock/ping-javascript-sdk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants