Clear error state when successful request #277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: fb041e0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
View your CI Pipeline Execution ↗ for commit fb041e0.
☁️ Nx Cloud last updated this comment at |
|
Deployed 0df3260 to https://ForgeRock.github.io/ping-javascript-sdk/pr-277/0df326011be4fc1537c878b861495656909040c7 branch gh-pages in ForgeRock/ping-javascript-sdk |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #277 +/- ##
==========================================
+ Coverage 50.26% 50.32% +0.05%
==========================================
Files 29 29
Lines 1711 1713 +2
Branches 195 194 -1
==========================================
+ Hits 860 862 +2
Misses 851 851
🚀 New features to boost your workflow:
|
cerebrl
approved these changes
May 27, 2025
ryanbas21
force-pushed
the
clear-error-state-when-successful-request
branch
3 times, most recently
from
72ca540 to
637e14b
Compare
cerebrl
approved these changes
Jun 2, 2025
ryanbas21
force-pushed
the
clear-error-state-when-successful-request
branch
from
637e14b to
fb041e0
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket
https://pingidentity.atlassian.net/browse/SDKS-4042
Description
Error states should clear once we have successfully processed a success or next node.