Skip to content

ci: make true a string in ci flow #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2025
Merged

ci: make true a string in ci flow #327

merged 1 commit into from
Jun 16, 2025

Conversation

ryanbas21
Copy link
Collaborator

JIRA Ticket

N/A

Description

Seems this has to be a string, not a boolean. noticed snapshot wasn't published iwth provenance

Copy link

nx-cloud bot commented Jun 16, 2025

View your CI Pipeline Execution ↗ for commit fd04e1d.

Command Status Duration Result
nx affected -t build typecheck lint test e2e-ci ✅ Succeeded 1m 2s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 1s View ↗

☁️ Nx Cloud last updated this comment at 2025-06-16 15:41:35 UTC

@ryanbas21 ryanbas21 force-pushed the fix-beta-provenance branch from 5e61028 to fd0daf9 Compare June 16, 2025 15:28
Copy link

changeset-bot bot commented Jun 16, 2025

⚠️ No Changeset found

Latest commit: fd04e1d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ryanbas21 ryanbas21 force-pushed the fix-beta-provenance branch from fd0daf9 to fd04e1d Compare June 16, 2025 15:33
Copy link
Contributor

Deployed d57c5ce to https://ForgeRock.github.io/ping-javascript-sdk/pr-327/d57c5ceff66177b93f0552028c93b9e85f1eb86a branch gh-pages in ForgeRock/ping-javascript-sdk

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.61%. Comparing base (752e81d) to head (fd04e1d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #327   +/-   ##
=======================================
  Coverage   61.61%   61.61%           
=======================================
  Files          33       33           
  Lines        1985     1985           
  Branches      287      287           
=======================================
  Hits         1223     1223           
  Misses        762      762           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ryanbas21 ryanbas21 merged commit 7eab116 into main Jun 16, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants