Skip to content

chore: update-external-idp-comment #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2025
Merged

chore: update-external-idp-comment #333

merged 1 commit into from
Jun 17, 2025

Conversation

ryanbas21
Copy link
Collaborator

No-op, just update a comment so its displayed better and accurately in lsp intellisense

Copy link

changeset-bot bot commented Jun 17, 2025

⚠️ No Changeset found

Latest commit: c98e65f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

nx-cloud bot commented Jun 17, 2025

View your CI Pipeline Execution ↗ for commit c98e65f.

Command Status Duration Result
nx run-many -t build ✅ Succeeded 2s View ↗
nx affected -t build typecheck lint test e2e-ci ✅ Succeeded 1m 35s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 1s View ↗

☁️ Nx Cloud last updated this comment at 2025-06-17 18:27:04 UTC

Copy link
Contributor

Deployed 70ce2de to https://ForgeRock.github.io/ping-javascript-sdk/pr-333/70ce2decc5ece180c48812ecd4554f04e7a854e4 branch gh-pages in ForgeRock/ping-javascript-sdk

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.46%. Comparing base (17171a5) to head (c98e65f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #333      +/-   ##
==========================================
- Coverage   61.61%   53.46%   -8.15%     
==========================================
  Files          33       20      -13     
  Lines        1985     1528     -457     
  Branches      287      183     -104     
==========================================
- Hits         1223      817     -406     
+ Misses        762      711      -51     
Files with missing lines Coverage Δ
packages/davinci-client/src/lib/client.store.ts 0.38% <ø> (ø)

... and 13 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ryanbas21 ryanbas21 merged commit 456e868 into main Jun 17, 2025
3 checks passed
@ryanbas21 ryanbas21 deleted the fix-comment branch June 17, 2025 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants