Always return new instance

FormidableLabs · Aug 4, 2023 · 749dd34 · 749dd34
1 parent bf32fda
commit 749dd34
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 6 deletions.
diff --git a/.changeset/moody-spoons-thank.md b/.changeset/moody-spoons-thank.md
@@ -0,0 +1,5 @@
+---
+"groqd": patch
+---
+
+Always return a new Class from builder methods, addresses #204.
diff --git a/packages/groqd/src/builder.ts b/packages/groqd/src/builder.ts
@@ -146,8 +146,10 @@ export class ArrayQuery<T extends z.ZodTypeAny> extends BaseQuery<
   }
 
   filter(filterValue = "") {
-    this.query += `[${filterValue}]`;
-    return this;
+    return new ArrayQuery<T>({
+      ...this.value(),
+      query: this.query + `[${filterValue}]`,
+    });
   }
 
   filterByType(filterTypeValue: string) {
@@ -200,13 +202,17 @@ export class ArrayQuery<T extends z.ZodTypeAny> extends BaseQuery<
   }
 
   order(...orderings: `${string} ${"asc" | "desc"}`[]): ArrayQuery<T> {
-    this.query += `|order(${orderings.join(", ")})`;
-    return this;
+    return new ArrayQuery<T>({
+      ...this.value(),
+      query: this.query + `|order(${orderings.join(", ")})`,
+    });
   }
 
   score(...scores: string[]): ArrayQuery<T> {
-    this.query += `|score(${scores.join(", ")})`;
-    return this;
+    return new ArrayQuery<T>({
+      ...this.value(),
+      query: this.query + `|score(${scores.join(", ")})`,
+    });
   }
 
   // Slicing